Repository navigation
Conversation
…is-fix x-axis/zoom fix for chromatogram
Jung-Choi-01
approved these changes
Oct 26, 2026
Jung-Choi-01
left a comment
Jung-Choi-01
left a comment
Collaborator
There was a problem hiding this comment.
- code looks good, yay shared component (maybe this could go into even more shared logic, but i don't imagine this would change much for different chromatographies so doing it this way is fine)
- tested error case, and put a debugger to watch timer go up for a while. works good
- fulfills issue criteria
cool!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add timer for fractionations, factored out of/based off of peptide retentions timer
closes #93